Added project_name optional field to user mappings ui (#9)#3743
Draft
satyamMIPL wants to merge 3 commits intosegmentio:mainfrom
Draft
Added project_name optional field to user mappings ui (#9)#3743satyamMIPL wants to merge 3 commits intosegmentio:mainfrom
satyamMIPL wants to merge 3 commits intosegmentio:mainfrom
Conversation
* fix: added project name to user mappings ui * fix: adding null check for properties in payload * fix: mapping moe field with project name * fix: test cases
joe-ayoub-segment
previously approved these changes
Apr 23, 2026
Contributor
|
Looks good to me @satyamMIPL . |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for an optional project_name mapping in the MoEngage trackEvent action so that (when provided) it is emitted as moe_project_name in the outbound event properties.
Changes:
- Introduces a new optional
project_nameaction field and maps it toproperties.moe_project_name. - Updates request construction to incorporate
moe_project_nameintoproperties. - Expands unit tests and updates snapshots to cover the new field behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/destination-actions/src/destinations/moengage/trackEvent/index.ts | Adds project_name field and injects moe_project_name into outbound properties. |
| packages/destination-actions/src/destinations/moengage/trackEvent/generated-types.ts | Updates generated payload typing to include project_name. |
| packages/destination-actions/src/destinations/moengage/trackEvent/tests/index.test.ts | Adds unit tests validating moe_project_name injection behavior. |
| packages/destination-actions/src/destinations/moengage/trackEvent/tests/snapshots/snapshot.test.ts.snap | Updates action snapshots for required/all-fields cases. |
| packages/destination-actions/src/destinations/moengage/tests/snapshots/snapshot.test.ts.snap | Updates destination-level snapshots impacted by the action payload shape. |
joe-ayoub-segment
approved these changes
Apr 27, 2026
Author
|
Hi @joe-ayoub-segment, we will be releasing this next week after few changes are confirmed on our end. Moving this PR to draft. |
Contributor
OK thanks @satyamMIPL I've removed it from the deploy tomorrow. Let me know when you want this to go out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A summary of your pull request, including the what change you're making and why.
We have added a new field called project_name in the user mappings to support multiple projects in a single workspace.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example